From 060daf2428ab51c2ef2a6ee6b90d7ebbfceebf10 Mon Sep 17 00:00:00 2001 From: "zhou.xu" Date: Tue, 24 Sep 2024 18:15:53 +0800 Subject: [PATCH] NEW:add "show_shells_in_preview" item in preferences jira: none Change-Id: I5cd0816b811608138c28f568cc5977966126baf6 --- src/libslic3r/AppConfig.cpp | 2 ++ src/slic3r/GUI/GUI_Preview.cpp | 4 ++-- src/slic3r/GUI/Preferences.cpp | 4 ++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/libslic3r/AppConfig.cpp b/src/libslic3r/AppConfig.cpp index 3634f0b0f..4db80bd7f 100644 --- a/src/libslic3r/AppConfig.cpp +++ b/src/libslic3r/AppConfig.cpp @@ -172,6 +172,8 @@ void AppConfig::set_defaults() if (get("zoom_to_mouse").empty()) set_bool("zoom_to_mouse", false); + if (get("show_shells_in_preview").empty()) + set_bool("show_shells_in_preview", true); if (get("enable_lod").empty()) set_bool("enable_lod", true); if (get("user_bed_type").empty()) diff --git a/src/slic3r/GUI/GUI_Preview.cpp b/src/slic3r/GUI/GUI_Preview.cpp index 23891e709..a4af47d00 100644 --- a/src/slic3r/GUI/GUI_Preview.cpp +++ b/src/slic3r/GUI/GUI_Preview.cpp @@ -734,8 +734,8 @@ void Preview::load_print_as_fff(bool keep_z_range, bool only_gcode) //BBS show sliders show_moves_sliders(); - //BBS: keep shell preview on - m_canvas->set_shells_on_previewing(true); + //BBS: keep shell preview on or not by app_config + m_canvas->set_shells_on_previewing(wxGetApp().app_config->get_bool("show_shells_in_preview")); Refresh(); zs = m_canvas->get_gcode_layers_zs(); //BBS: add m_loaded_print logic diff --git a/src/slic3r/GUI/Preferences.cpp b/src/slic3r/GUI/Preferences.cpp index 14a2e8ae2..287ec0c6c 100644 --- a/src/slic3r/GUI/Preferences.cpp +++ b/src/slic3r/GUI/Preferences.cpp @@ -1130,6 +1130,9 @@ wxWindow* PreferencesDialog::create_general_page() auto item_mouse_zoom_settings = create_item_checkbox(_L("Zoom to mouse position"), page, _L("Zoom in towards the mouse pointer's position in the 3D view, rather than the 2D window center."), 50, "zoom_to_mouse"); + auto item_show_shells_in_preview_settings = create_item_checkbox(_L("Always show shells in preview"), page, + _L("Always show shells or not in preview view tab.If change value,you should reslice."), 50, + "show_shells_in_preview"); auto enable_lod_settings = create_item_checkbox(_L("Improve rendering performance by lod"), page, _L("Improved rendering performance under the scene of multiple plates and many models."), 50, "enable_lod"); @@ -1215,6 +1218,7 @@ wxWindow* PreferencesDialog::create_general_page() sizer_page->Add(item_beta_version_update, 0, wxTOP, FromDIP(3)); sizer_page->Add(_3d_settings, 0, wxTOP | wxEXPAND, FromDIP(20)); sizer_page->Add(item_mouse_zoom_settings, 0, wxTOP, FromDIP(3)); + sizer_page->Add(item_show_shells_in_preview_settings, 0, wxTOP, FromDIP(3)); sizer_page->Add(enable_lod_settings, 0, wxTOP, FromDIP(3)); sizer_page->Add(item_grabber_size_settings, 0, wxTOP, FromDIP(3)); sizer_page->Add(title_presets, 0, wxTOP | wxEXPAND, FromDIP(20));