From 35b0ef0cd7bbb3a3e06231863cf2d855e74b56cc Mon Sep 17 00:00:00 2001
From: tao wang <tao.wang@bambulab.com>
Date: Thu, 17 Oct 2024 10:34:11 +0800
Subject: [PATCH] FIX:fix the issue of macOS crashing easily

Change-Id: I7378a28734e46c4126ab0216dc93d45a10bcd451
---
 src/slic3r/GUI/SelectMachine.cpp | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/src/slic3r/GUI/SelectMachine.cpp b/src/slic3r/GUI/SelectMachine.cpp
index ee6c5b00b..99071b454 100644
--- a/src/slic3r/GUI/SelectMachine.cpp
+++ b/src/slic3r/GUI/SelectMachine.cpp
@@ -4566,16 +4566,21 @@ void SelectMachineDialog::sys_color_changed()
 
 bool SelectMachineDialog::Show(bool show)
 {
-    show_status(PrintDialogStatus::PrintStatusInit);
-
     // set default value when show this dialog
     if (show) {
+        m_refresh_timer->Start(LIST_REFRESH_INTERVAL);
+        show_status(PrintDialogStatus::PrintStatusInit);
         wxGetApp().UpdateDlgDarkUI(this);
         wxGetApp().reset_to_active();
         set_default();
         update_user_machine_list();
+
+        Layout();
+        Fit();
+        CenterOnParent();
     }
     else {
+        m_refresh_timer->Stop();
         DeviceManager* dev = Slic3r::GUI::wxGetApp().getDeviceManager();
         if (dev) {
             MachineObject* obj_ = dev->get_selected_machine();
@@ -4587,15 +4592,6 @@ bool SelectMachineDialog::Show(bool show)
             }
         }
     }
-
-    if (show) {
-        m_refresh_timer->Start(LIST_REFRESH_INTERVAL);
-    } else {
-        m_refresh_timer->Stop();
-    }
-    Layout();
-    Fit();
-    if (show) { CenterOnParent(); }
     return DPIDialog::Show(show);
 }