From 40654323b0f48d1349640f50c9427b77db668865 Mon Sep 17 00:00:00 2001 From: "xun.zhang" Date: Tue, 11 Mar 2025 11:46:14 +0800 Subject: [PATCH] FIX: opposite value for detect floating vshell 1. Also add default values in profile jira:NONE Signed-off-by: xun.zhang Change-Id: I70eb017a63fa55b40f3f62b4f31da0179ebc5abc --- resources/profiles/BBL.json | 2 +- resources/profiles/BBL/process/fdm_process_common.json | 1 + resources/profiles/BBL/process/fdm_process_dual_common.json | 6 ++++++ .../profiles/BBL/process/fdm_process_single_common.json | 3 +++ src/libslic3r/Fill/FillContour.cpp | 2 +- src/libslic3r/PrintConfig.cpp | 2 +- 6 files changed, 13 insertions(+), 3 deletions(-) diff --git a/resources/profiles/BBL.json b/resources/profiles/BBL.json index e32a6a146..97ef32e34 100644 --- a/resources/profiles/BBL.json +++ b/resources/profiles/BBL.json @@ -1,7 +1,7 @@ { "name": "Bambulab", "url": "http://www.bambulab.com/Parameters/vendor/BBL.json", - "version": "02.00.00.54", + "version": "02.00.00.55", "force_update": "0", "description": "the initial version of BBL configurations", "machine_model_list": [ diff --git a/resources/profiles/BBL/process/fdm_process_common.json b/resources/profiles/BBL/process/fdm_process_common.json index ae4887f01..763107d34 100644 --- a/resources/profiles/BBL/process/fdm_process_common.json +++ b/resources/profiles/BBL/process/fdm_process_common.json @@ -19,6 +19,7 @@ "default_acceleration": [ "10000" ], + "detect_floating_vertical_shell": "1", "detect_overhang_wall": "1", "detect_thin_wall": "0", "draft_shield": "disabled", diff --git a/resources/profiles/BBL/process/fdm_process_dual_common.json b/resources/profiles/BBL/process/fdm_process_dual_common.json index ab6b214cb..b11a3d908 100644 --- a/resources/profiles/BBL/process/fdm_process_dual_common.json +++ b/resources/profiles/BBL/process/fdm_process_dual_common.json @@ -179,5 +179,11 @@ "0", "0" ], + "vertical_shell_speed": [ + "80%", + "80%", + "80%", + "80%" + ], "z_direction_outwall_speed_continuous": "1" } \ No newline at end of file diff --git a/resources/profiles/BBL/process/fdm_process_single_common.json b/resources/profiles/BBL/process/fdm_process_single_common.json index de4d16ba3..d7dd5612b 100644 --- a/resources/profiles/BBL/process/fdm_process_single_common.json +++ b/resources/profiles/BBL/process/fdm_process_single_common.json @@ -78,5 +78,8 @@ ], "travel_speed_z": [ "0" + ], + "vertical_shell_speed": [ + "80%" ] } \ No newline at end of file diff --git a/src/libslic3r/Fill/FillContour.cpp b/src/libslic3r/Fill/FillContour.cpp index 20cc39251..4ff1c7dad 100644 --- a/src/libslic3r/Fill/FillContour.cpp +++ b/src/libslic3r/Fill/FillContour.cpp @@ -684,7 +684,7 @@ FloatingThickPolylines FillContour::resplit_order_loops(Point curr_point, std::v if (all_extrusions[idx]->empty()) continue; ThickPolyline thick_polyline = Arachne::to_thick_polyline(*all_extrusions[idx]); - FloatingThickPolyline thick_line_with_floating = detect_floating_line(thick_polyline, floating_areas, default_width, print_object_config->detect_floating_vertical_shell.value); + FloatingThickPolyline thick_line_with_floating = detect_floating_line(thick_polyline, floating_areas, default_width, !print_object_config->detect_floating_vertical_shell.value); smooth_floating_line(thick_line_with_floating, scale_(2), scale_(2)); int split_idx = 0; if (!floating_areas.empty() && all_extrusions[idx]->is_closed && thick_line_with_floating.points.front() == thick_line_with_floating.points.back()) { diff --git a/src/libslic3r/PrintConfig.cpp b/src/libslic3r/PrintConfig.cpp index 5a52622c5..879683540 100644 --- a/src/libslic3r/PrintConfig.cpp +++ b/src/libslic3r/PrintConfig.cpp @@ -1378,7 +1378,7 @@ void PrintConfigDef::init_fff_params() def->label = L("Detect floating vertical shells"); def->tooltip = L("Detect floating vertical shells and slow them by using bridge speed."); def->mode = comAdvanced; - def->set_default_value(new ConfigOptionBool{false}); + def->set_default_value(new ConfigOptionBool{true}); def = this->add("internal_bridge_support_thickness", coFloat); def->label = L("Internal bridge support thickness");