From ba8015e4555367f2e0ca1e4594da74a103ee14d5 Mon Sep 17 00:00:00 2001 From: "chunmao.guo" Date: Wed, 30 Nov 2022 09:20:04 +0800 Subject: [PATCH] FIX: more web view logs Change-Id: Ia4b2821188c3053be297b0fe0aa19fb8d939a816 (cherry picked from commit 4e76cfc6529038252a4afd8d53cf93f817d46b01) --- src/slic3r/GUI/WebViewDialog.cpp | 12 ++++++++++-- src/slic3r/GUI/Widgets/WebView.cpp | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/slic3r/GUI/WebViewDialog.cpp b/src/slic3r/GUI/WebViewDialog.cpp index 3b9406ab9..a77a90def 100644 --- a/src/slic3r/GUI/WebViewDialog.cpp +++ b/src/slic3r/GUI/WebViewDialog.cpp @@ -471,6 +471,7 @@ void WebViewPanel::update_mode() */ void WebViewPanel::OnNavigationRequest(wxWebViewEvent& evt) { + BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << ": " << evt.GetTarget().ToUTF8().data(); const wxString &url = evt.GetURL(); if (url.StartsWith("File://") || url.StartsWith("file://")) { if (!url.Contains("/web/homepage/index.html")) { @@ -506,6 +507,7 @@ void WebViewPanel::OnNavigationRequest(wxWebViewEvent& evt) */ void WebViewPanel::OnNavigationComplete(wxWebViewEvent& evt) { + BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << ": " << evt.GetTarget().ToUTF8().data(); if (wxGetApp().get_mode() == comDevelop) wxLogMessage("%s", "Navigation complete; url='" + evt.GetURL() + "'"); UpdateState(); @@ -516,7 +518,8 @@ void WebViewPanel::OnNavigationComplete(wxWebViewEvent& evt) */ void WebViewPanel::OnDocumentLoaded(wxWebViewEvent& evt) { - //Only notify if the document is the main frame, not a subframe + BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << ": " << evt.GetTarget().ToUTF8().data(); + // Only notify if the document is the main frame, not a subframe if (evt.GetURL() == m_browser->GetCurrentURL()) { if (wxGetApp().get_mode() == comDevelop) @@ -528,6 +531,7 @@ void WebViewPanel::OnDocumentLoaded(wxWebViewEvent& evt) void WebViewPanel::OnTitleChanged(wxWebViewEvent &evt) { + BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << ": " << evt.GetString().ToUTF8().data(); // wxGetApp().CallAfter([this] { SendRecentList(); }); } @@ -536,6 +540,7 @@ void WebViewPanel::OnTitleChanged(wxWebViewEvent &evt) */ void WebViewPanel::OnNewWindow(wxWebViewEvent& evt) { + BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << ": " << evt.GetURL().ToUTF8().data(); wxString flag = " (other)"; if (evt.GetNavigationAction() == wxWEBVIEW_NAV_ACTION_USER) @@ -556,6 +561,7 @@ void WebViewPanel::OnNewWindow(wxWebViewEvent& evt) void WebViewPanel::OnScriptMessage(wxWebViewEvent& evt) { + BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << ": " << evt.GetString().ToUTF8().data(); // update login status if (m_LoginUpdateTimer == nullptr) { BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << " Create Timer"; @@ -784,7 +790,7 @@ void WebViewPanel::OnSelectAll(wxCommandEvent& WXUNUSED(evt)) void WebViewPanel::OnError(wxWebViewEvent& evt) { #define WX_ERROR_CASE(type) \ -case type: \ + case type: \ category = #type; \ break; @@ -801,6 +807,8 @@ case type: \ WX_ERROR_CASE(wxWEBVIEW_NAV_ERR_OTHER); } + BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << ": [" << category << "] " << evt.GetString().ToUTF8().data(); + if (wxGetApp().get_mode() == comDevelop) wxLogMessage("%s", "Error; url='" + evt.GetURL() + "', error='" + category + " (" + evt.GetString() + ")'"); diff --git a/src/slic3r/GUI/Widgets/WebView.cpp b/src/slic3r/GUI/Widgets/WebView.cpp index c835f3cfb..db0628a2b 100644 --- a/src/slic3r/GUI/Widgets/WebView.cpp +++ b/src/slic3r/GUI/Widgets/WebView.cpp @@ -102,7 +102,7 @@ wxWebView* WebView::CreateWebView(wxWindow * parent, wxString const & url) url2.Replace("\\", "/"); #endif if (!url2.empty()) { url2 = wxURI(url2).BuildURI(); } - BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << url2.ToUTF8(); + BOOST_LOG_TRIVIAL(info) << __FUNCTION__ << ": " << url2.ToUTF8(); auto webView = wxWebView::New(); if (webView) {