mozhe
/
BambuStudio
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FIX: Revert "ENH: do not leave a gap for top... 

Revert "ENH: do not leave a gap for top interface if the top z distance is 0"

This reverts commit 79ea32c7cbbdb7e689637980af7c36caf42284c9.

Revert reason: the supports are impossible to remove in some cases.
jira: STUDIO-5385

Change-Id: I376a6f4dfd78da6dfea68b9ac3d552cddd0b4272
(cherry picked from commit 34e38b705fde7f5d7f9a3a89c96a3627ce0c998e)
This commit is contained in:
Arthur 2023-11-24 19:40:21 +08:00 committed by Lane.Wei
parent 879880cc80
commit d257c0f90d
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/libslic3r/Support/SupportMaterial.cpp
View File

@ -3278,9 +3278,7 @@ void PrintObjectSupportMaterial::trim_support_layers_by_object(
// perimeter's width. $support contains the full shape of support // perimeter's width. $support contains the full shape of support
// material, thus including the width of its foremost extrusion. // material, thus including the width of its foremost extrusion.
// We leave a gap equal to a full extrusion width. // We leave a gap equal to a full extrusion width.
// arthur: do not leave a gap for top interface if the top z distance is 0. support_layer.polygons = diff(support_layer.polygons, polygons_trimming);
if (support_layer.layer_type != sltTopContact || m_slicing_params.gap_support_object != 0)
support_layer.polygons = diff(support_layer.polygons, polygons_trimming);
} }
}); });
BOOST_LOG_TRIVIAL(debug) << "PrintObjectSupportMaterial::trim_support_layers_by_object() in parallel - end"; BOOST_LOG_TRIVIAL(debug) << "PrintObjectSupportMaterial::trim_support_layers_by_object() in parallel - end";

5
src/libslic3r/Support/TreeSupport.cpp
View File

@ -2337,9 +2337,8 @@ void TreeSupport::draw_circles(const std::vector<std::vector<Node*>>& contact_no
roof_1st_layer = std::move(offset2_ex(roof_1st_layer, contact_dist_scaled, -contact_dist_scaled)); roof_1st_layer = std::move(offset2_ex(roof_1st_layer, contact_dist_scaled, -contact_dist_scaled));
// avoid object // avoid object
// arthur: do not leave a gap for top interface if the top z distance is 0. See STUDIO-3991 //ExPolygons avoid_region_interface = m_ts_data->get_collision(m_ts_data->m_xy_distance, layer_nr);
Polygons avoid_region_interface = get_trim_support_regions(*m_object, ts_layer, m_slicing_params.gap_object_support, m_slicing_params.gap_support_object, Polygons avoid_region_interface = get_trim_support_regions(*m_object, ts_layer, m_slicing_params.gap_object_support, m_slicing_params.gap_support_object, m_ts_data->m_xy_distance);
m_slicing_params.gap_support_object == 0 ? 0 : m_ts_data->m_xy_distance);
if (has_circle_node) { if (has_circle_node) {
roof_areas = avoid_object_remove_extra_small_parts(roof_areas, avoid_region_interface); roof_areas = avoid_object_remove_extra_small_parts(roof_areas, avoid_region_interface);
roof_1st_layer = avoid_object_remove_extra_small_parts(roof_1st_layer, avoid_region_interface); roof_1st_layer = avoid_object_remove_extra_small_parts(roof_1st_layer, avoid_region_interface);